Adalennis commented on PR #9620:
URL: https://github.com/apache/hop/pull/9620#issuecomment-7063803920

   Thanks for the review, @hansva. All four remarks are addressed in the 
updated commit:
   
   - Child generate 1000 rows: the transform and its hop are now named 
child-loops-get-rows-from-result.hpl. The sample still runs 10 executions of 
100 rows each.
   - Get table names: the page now says that procedures and synonyms are 
switched on, but hop-samples returns none. H2DatabaseMeta doesn't support 
synonyms, and the database has no procedures of its own.
   - Fuzzy match: the sentence now names new_address.
   - Filter rows: the sample file names appear only in the Samples section, and 
the rest of the page links to it or to MDI Example. That also covers three 
older mentions higher up the page.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to