Adalennis opened a new pull request, #9636:
URL: https://github.com/apache/hop/pull/9636

   Addresses #9469
   
   Adds a Samples section to 29 transform pages, Group by to Metadata structure 
of stream. Each sentence was checked by running the sample with Hop built from 
main, except the JMS, Kafka, LDAP and Mail samples, which need a server or a 
connection that the samples project doesn't have and were checked from their 
settings.
   
   - JSON Input and Metadata Injection already listed their samples in the 
text. That text now points to the Samples section, so the file names are in one 
place.
   - `transforms/json-input-public-holidays-from-rest.hpl` read the date with 
the mask `YYYY-mm-dd` (week year and minutes), so every holiday fell on the 
first day of its month. The mask is now `yyyy-MM-dd`.
   - 
`transforms/javascript-cross-convert-between-julian-dates-and-iso-dates.hpl` 
built the ISO date with `Date.UTC(year, 0, day + 1)`, which is only right west 
of UTC: in Brussels every date came out one day late. It now uses `new 
Date(year, 0, day)`, which is right in Brussels and in Los Angeles.
   - `transforms/json-input-nested-elements.hpl` reads 
`metadata/pipeline-run-configuration/DataFlow.json`, which comes with the Beam 
plugin, so without that plugin it returns no rows. The JSON Input page says so; 
the sample is unchanged.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to