hansva opened a new issue, #9645:
URL: https://github.com/apache/hop/issues/9645
### What would you like to happen?
A Hop install cannot tell which plugin put which jar in `lib/core`. So an
uninstall cannot
remove shared jars, a fat jar cannot leave out what a project does not use,
and nobody
checks that a plugin really ships everything it needs. Today a plugin can
work only because
another plugin happens to bring a jar along.
### Proposal
- **Plugin manifests.** Every plugin zip carries `plugin-manifest.json` with:
- every file it installs, with its location, Maven coordinates, size and
SHA-256;
- its plugin ids;
- the plugins it requires.
The client carries `lib/core/hop-client-manifest.json` for its own jars.
`PluginManifestScanner` maps every file of an install to the manifests
that claim it.
- **`hop-maven-plugin`.** A new module with the goal `hop:manifest`, which
adds the manifest
to a plugin zip. Hop's build uses it, and an external plugin only binds
the goal after its
assembly, as it does for Jandex. The manifest is appended without
rewriting the zip and
takes the time of the zip's other entries, so builds stay reproducible.
- **Isolation check.** `tools/check-plugins-isolated.sh` installs each
plugin on a client
without plugins, plus only the plugins it declares. It then checks that:
- its classes link;
- its plugins register;
- it needs nothing that only other plugins would ship.
It runs in two tiers: headless (no SWT) and with SWT. The bare clients are
built with
`-Dhop.bare.skip=false`.
### Result
- All 311 plugin zips and the client zip are byte-identical across two
builds.
- Every jar in `lib/core` and `lib/jdbc` is claimed by at least one manifest.
- The isolation check passes for all plugins on both tiers. Two are
allowlisted: Vertica's
JDBC driver is not bundled.
Depends on #9639 and #9643.
### Issue Priority
Priority: 2
### Issue Component
Component: API, Component: Beam, Component: Infrastructure, Component: Spark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]