[
https://issues.apache.org/jira/browse/HTRACE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279970#comment-14279970
]
Colin Patrick McCabe commented on HTRACE-81:
--------------------------------------------
Yeah, this is the last bit of source files that are still generated into the
src/ directory. HTRACE-67 moved all downloaded files into a separate build/
directory and got rid of the generated version.go.
I do think we should stop generating this, or at least generate it into the
build/ directory. I don't think it's very high priority but it would be nice
build improvement.
> Don't include generated files in src tar ball
> ---------------------------------------------
>
> Key: HTRACE-81
> URL: https://issues.apache.org/jira/browse/HTRACE-81
> Project: HTrace
> Issue Type: Bug
> Affects Versions: 3.1.0, master
> Reporter: stack
> Assignee: stack
>
> From [~billie.rinaldi]'s feedback on RC9 of 3.1.0:
> {code}
> The only unusual thing I noticed was that there are some generated sources
> in this resource directory that were not present when I built the tarball
> myself (listed below). Given that they are generated sources with license
> headers and our LICENSE file covers the content in them, maybe it's not a
> reason to fail the RC? I'm not sure how these got there, though; they go
> away with 'mvn clean'.
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__app.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__mock.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__models__span.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__setup.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__views__search.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/app__views__span.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/catalog.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/index.html.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap-theme.css.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap-theme.css.map.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap-theme.min.css.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap.css.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap.css.map.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__css__bootstrap.min.css.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__js__bootstrap.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__js__bootstrap.min.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__bootstrap-3.3.1__js__npm.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__css__main.css.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__js__backbone-1.1.2.min.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__js__jquery-2.1.3.min.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/lib__js__underscore-1.7.0.min.js.go
> htrace-3.1.0-incubating/htrace-core/src/go/src/org/apache/htrace/resource/nested__nested.html.go
> {code}
> Let me include rules to exclude generated files in src tarball.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
