[
https://issues.apache.org/jira/browse/HTRACE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329315#comment-14329315
]
stack commented on HTRACE-111:
------------------------------
+1
Builder is nicer and good you changed all tests so folks have no chance of
getting wrong idea.
nit to fix on commit: if (span.getParents().length == 0) { should be
isEmpty?
Q: If no begin, do we not default this: begin(System.currentTimeMillis() ?
I like this. This is a better way of saying 'no parent': if
(span.getParents().length == 0) { Do you think it worth adding a 'hasParent'
convenience method?
> HTrace Java client API fixes for 3.2
> ------------------------------------
>
> Key: HTRACE-111
> URL: https://issues.apache.org/jira/browse/HTRACE-111
> Project: HTrace
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Critical
> Attachments: HTRACE-111.001.patch
>
>
> * Remove old MilliSpan constructors in favor of {{MilliSpan#Builder}}
> * Restore {{Trace#startSpan(String, TraceInfo)}} because it's used in Hadoop
> * Remove {{Span#getParentId}} API which assumes a single parent world, as
> well as {{ROOT_SPAN_ID}}.
> * Use regular Random instead of SecureRandom.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
