[ 
https://issues.apache.org/jira/browse/HTRACE-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14330053#comment-14330053
 ] 

stack commented on HTRACE-112:
------------------------------

Make this a reusable static?     ByteBuffer newlineBuf = ByteBuffer.wrap(new 
byte[] { (byte)0xa });  If so, its nit so fix on commit.

Looking at rest of patch it LGTM. +1.


> Fix LocalFileSpanReceiver to avoid BG thread and problems around close()
> ------------------------------------------------------------------------
>
>                 Key: HTRACE-112
>                 URL: https://issues.apache.org/jira/browse/HTRACE-112
>             Project: HTrace
>          Issue Type: Bug
>    Affects Versions: 3.2.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-112.001.patch
>
>
> When testing the HDFS client with htrace, LocalFileSpanReceiver was giving me 
> "Channel closed" exceptions.  I think this is because of a race between 
> closing the span receiver and flushing the spans from that receiver.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to