[
https://issues.apache.org/jira/browse/HTRACE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335841#comment-14335841
]
Abraham Elmahrek commented on HTRACE-104:
-----------------------------------------
# htrace-core/src/go/src/org/apache/htrace/client/client.go#164: I'm a bit
naive here, but are span IDs guarantee to be a positive number? If so, I feel
like we should be using uint64 every where.
# htrace-core/src/go/src/org/apache/htrace/common/query.go#63: Valid ops is
listed twice. Not a big deal though. Same is true for field. It seems like
golang is lacking a library function for testing the existence of an object in
an array of objects.
# htrace-core/src/go/gobuild.sh: Just making sure the modifications to this
file is intended?
# htrace-core/src/go/src/org/apache/htrace/htrace/cmd.go: Why not keep some
base ops (ie: dump/load/graph/query) and just have options on these ops (ie:
-all)?
Awesome dot graph generation! Does https://code.google.com/p/gographviz/ not
work?
> htrace command should support generating graphviz files and making htraced
> queries
> ----------------------------------------------------------------------------------
>
> Key: HTRACE-104
> URL: https://issues.apache.org/jira/browse/HTRACE-104
> Project: HTrace
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-104.001.patch, HTRACE-104.002.patch
>
>
> The htrace command should support generating graphviz files and making
> htraced queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
