[
https://issues.apache.org/jira/browse/HTRACE-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337477#comment-14337477
]
Colin Patrick McCabe commented on HTRACE-116:
---------------------------------------------
{{query.go}}: gofmt cleanup
{{mini_htraced.go}}: rather than having the caller supply {{NumDataDirs}}, have
the caller supply an array of strings specifying the data directories. Entries
which are empty strings will be replaced with randomly created directories.
Add {{MiniHTraced#KeepOnClose}} for unit tests that want to close the
{{MiniHTraced}} cluster object without deleting the storage directories.
{{client_test.go}}: update based on changes to {{mini_htraced.go}}
{{datastore.go}}: rather than storing a metadata structure in the datastore,
store a single {{uint32}}. This will be the layout version. We will increment
it whenever the format of the data in the datastore changes. Define
{{UNKNOWN_LAYOUT_VERSION}} as 0 and add a constant for
{{CURRENT_LAYOUT_VERSION}}. In {{CreateShard}}, fix the logic so that we don't
attempt to open datastores which have the wrong version. Also fix clearing the
datastore when {{data.store.clear = true}}. This was broken earlier because
{{os.MkdirAll}} does not return an error if the specified directories already
exist, and the code assumed that it did. Fix a few log messages lacking
newlines.
{{datastore_test.go}}: add a test of reloading a datastore of the same version.
Also test that if the datastore version is wrong, we refuse to load.
> htraced's data.store.clear option does not work
> -----------------------------------------------
>
> Key: HTRACE-116
> URL: https://issues.apache.org/jira/browse/HTRACE-116
> Project: HTrace
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-116.001.patch
>
>
> htraced's data.store.clear option does not work right now. We should fix
> this. We should also have it not start up when the datastore version is too
> old and data.store.clear is not set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
