[
https://issues.apache.org/jira/browse/HTRACE-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338993#comment-14338993
]
Colin Patrick McCabe commented on HTRACE-115:
---------------------------------------------
bq. ... we do not do math with spanids, right? And we flip the bit only if not
already flipped (The ret ^= 0x8000000000000000 ) ? If so, suggest adding to
comment.
Yeah, we don't do math with spanids. It's a good thing, too, since spanids can
be really big or really small, so doing things like subtracting the two could
lead to overflow :) Also, the spanids don't get the high bit flipped since
they are u64 all the time.
bq. I did grep of 'int64' and loads of places... you had a look to make sure
you have them all?
yeah, the remaining ones are begin, end, duration, etc. and other misc uses
committed to 3.2
> The htraced datastore should use uint64 for span ids rather than int64
> ----------------------------------------------------------------------
>
> Key: HTRACE-115
> URL: https://issues.apache.org/jira/browse/HTRACE-115
> Project: HTrace
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 3.2.0
>
> Attachments: HTRACE-115.001.patch
>
>
> Currently we manipulate span IDs as int64 rather than uint64 in some places
> in the htraced datastore. This is wrong since it makes the comparison
> operators work differently than would be expected. We should fix it to use
> uint64.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
