[
https://issues.apache.org/jira/browse/HTRACE-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343843#comment-14343843
]
Colin Patrick McCabe commented on HTRACE-127:
---------------------------------------------
bq. I suppose the flush before close is just in case? Probably not needed?
It's needed. The rationale is that the buffer inside the {{io.Writer}} object
needs to be flushed out to the file before the file is closed.
Committed, thanks
> fix ./build/htrace dumpAll
> --------------------------
>
> Key: HTRACE-127
> URL: https://issues.apache.org/jira/browse/HTRACE-127
> Project: HTrace
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 3.2.0
>
> Attachments: HTRACE-127.002.patch
>
>
> Fix {{./build/htrace dumpAll}}. An inverted conditional means that it
> currently doesn't dump any spans to the provided file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
