[
https://issues.apache.org/jira/browse/HTRACE-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570441#comment-14570441
]
Masatake Iwasaki commented on HTRACE-174:
-----------------------------------------
I tried the patch and search fuctionality worked. The code overall looks good
to me. I agree to keep it simple and easier to debug.
Search results are shown as plain json string in single page. Pagination is out
of the scope of this JIRA?
in span.js,
* Any value is not set to {{span}}. {{this.set("spanId", xxx)}} should be
{{span\["spanId"\] = xxx}}
* fomatting is not consistent for "parents".
{code}
parse: function(response, options) {
var span = {};
this.set("spanId", response.s ? response.s : INVALID_SPAN_ID);
this.set("traceId", response.i ? response.i : INVALID_SPAN_ID);
this.set("processId", response.r ? response.r : "");
if (response.p) {
this.set("parents", response.p);
} else {
this.set("parents", []);
}
this.set("description", response.d ? response.d : "");
this.set("begin", response.b ? parseInt(response.b, 10) : 0);
this.set("end", response.e ? parseInt(response.e, 10) : 0);
return span;
}
{code}
> Refactor GUI to fix pagination, form validation, about screen
> -------------------------------------------------------------
>
> Key: HTRACE-174
> URL: https://issues.apache.org/jira/browse/HTRACE-174
> Project: HTrace
> Issue Type: Bug
> Affects Versions: 3.1.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-174.001.patch
>
>
> Refactor the GUI to fix pagination, form validation, and add an about screen.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
