[ 
https://issues.apache.org/jira/browse/HTRACE-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578200#comment-14578200
 ] 

Colin Patrick McCabe commented on HTRACE-175:
---------------------------------------------

Good point.  I think it makes sense to provide a setter for {{addKVAnnotation}} 
in {{Tracer}}.  I don't think we should provide one for {{processId}} since 
most of the time you just want the default process ID determined by htrace.  
Can you post a new patch with just the {{addKVAnnotation}} change?

> Add missing setX functionality to Trace
> ---------------------------------------
>
>                 Key: HTRACE-175
>                 URL: https://issues.apache.org/jira/browse/HTRACE-175
>             Project: HTrace
>          Issue Type: Improvement
>            Reporter: Daniel Lee
>            Priority: Minor
>              Labels: patch
>         Attachments: 
> 0001-Add-missing-Span-setX-functionality-to-Trace-class.patch
>
>
> Trace currently doesn't expose a few options that are available to spans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to