[
https://issues.apache.org/jira/browse/HTRACE-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582426#comment-14582426
]
stack commented on HTRACE-180:
------------------------------
bq. I guess perhaps it's confusing that those build directories have "src" in
the path, even though they contain build products.
Yeah. Trashes src dir.
bq. Perhaps we should move htrace-htraced/src/go to htrace-htraced/go to avoid
this confusion?
My patch has go build into htrace-htraced/target rather than
htrace-htraced/src/go/build. htrace-htraced/src/go seems fine as location for
src.
bq. I think we should just change the default value of HTRACED_WEB_DIR to be
the relative path to the htrace-gui project.
Ok. That'll work too.
On the PoC patch, I'd rather set HTRACED_WEB_DIR to point at htrace-webapp when
doing dev rather than do this:
282 webdir, err =
filepath.Abs(filepath.Join(filepath.Dir(os.Args[0]),
283 "..", "..", "..", "..", "htrace-gui"));
The above will be ugly as a relative location having the htraced binary reach
up so high in the hierarchy. Default should be something like it was before:
webdir, err = filepath.Abs(filepath.Join(filepath.Dir(os.Args[0]), "..", "..",
"web"));
Will do up a patch that depends on dev setting HTRACED_WEB_DIR when they want
to do webapp dev.
Thanks.
> Move the GUI to a top-level subproject
> --------------------------------------
>
> Key: HTRACE-180
> URL: https://issues.apache.org/jira/browse/HTRACE-180
> Project: HTrace
> Issue Type: Improvement
> Reporter: Colin Patrick McCabe
> Assignee: stack
> Attachments: 180.txt, HTRACE-180.002.proof-of-concept.patch
>
>
> Move the GUI to a top-level subproject, so that we can use it for
> htrace-hbase as well as htrace-htraced (and possibly other subprojects in the
> future)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
