[
https://issues.apache.org/jira/browse/HTRACE-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582643#comment-14582643
]
Colin Patrick McCabe commented on HTRACE-178:
---------------------------------------------
Yeah, I guess it makes sense to use {{instanceof}} here.
Thanks for the patch, [~MattNelson].
TestTraceExecutorService.java: we should use 2-space indent, not hard tabs in
the java source
TraceExecutorService#wrap: since this may or may not wrap, can we call this
{{wrapIfNeeded}} perhaps?
> Do not wrap already wrapped runnables
> -------------------------------------
>
> Key: HTRACE-178
> URL: https://issues.apache.org/jira/browse/HTRACE-178
> Project: HTrace
> Issue Type: Improvement
> Reporter: Matt Nelson
> Priority: Minor
> Attachments:
> 0001-HTRACE-178.-Do-not-double-wrap-runnable-callable.patch
>
>
> When submitting items to the TraceExecutorService, if the item is already
> wrapped with TraceRunnable/TraceCallable it results in a dual wrapping and
> dual span reporting. Submit should perform an instanceof check to avoid this
> scenario.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
