[ 
https://issues.apache.org/jira/browse/HTRACE-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618123#comment-14618123
 ] 

Masatake Iwasaki commented on HTRACE-204:
-----------------------------------------

The patch looks good to me.

Just some nits.

I think this should be removed before check-in.
{code}
110         console.trace();
{code}

There is unnecessary addition of blank line.
{code}
@@ -219,6 +241,7 @@ htrace.SearchResultsView = Backbone.View.extend({
     this.timeCursor.yF = this.canvasY;
     this.timeCursor.begin = this.begin;
     this.timeCursor.end = this.end;
+
   },
{code}


> htrace-web: add draggable bar which allows more or less visual space for 
> process name in search view
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HTRACE-204
>                 URL: https://issues.apache.org/jira/browse/HTRACE-204
>             Project: HTrace
>          Issue Type: Improvement
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-204.001.patch, resize2.png
>
>
> htrace-web: add draggable bar which allows more or less visual space for 
> process name in search view



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to