[
https://issues.apache.org/jira/browse/HTRACE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin Patrick McCabe updated HTRACE-214:
----------------------------------------
Description:
De-globalize Tracer.java.
Currently, Tracer is a Singleton managed by TracerHolder. Instead, Tracer
objects should be created by each process or library that needs to use HTrace.
This enables a few things:
* When the Tracer object is created, we can give it a name. Then we can use
this name in the "process id" of all spans created by that tracer, rather than
trying to scrape the JVM name using "questionable" methods.
* SpanReceivers can be shared between multiple Tracer objects in the same
process. The span receivers are reference counted. This should eliminate the
"double tracing" issues we have had when tracing client libraries inside
processes which also want tracing.
* Tracers can be closed by calling Tracer#close. If the Tracer being closed is
the last tracer in the process, it will close all the span receivers.
* We will have a TracerFactory that takes care of the details of creating the
right span receivers based on the configuration. This removes some boilerplate
that is currently needed to enable HTrace in an application or library. We can
also make SpanReceiverFactory package-private since it will no longer need to
be publicly visible.
was:De-globalize Tracer.java.
> De-globalize Tracer.java
> ------------------------
>
> Key: HTRACE-214
> URL: https://issues.apache.org/jira/browse/HTRACE-214
> Project: HTrace
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
>
> De-globalize Tracer.java.
> Currently, Tracer is a Singleton managed by TracerHolder. Instead, Tracer
> objects should be created by each process or library that needs to use
> HTrace. This enables a few things:
> * When the Tracer object is created, we can give it a name. Then we can use
> this name in the "process id" of all spans created by that tracer, rather
> than trying to scrape the JVM name using "questionable" methods.
> * SpanReceivers can be shared between multiple Tracer objects in the same
> process. The span receivers are reference counted. This should eliminate
> the "double tracing" issues we have had when tracing client libraries inside
> processes which also want tracing.
> * Tracers can be closed by calling Tracer#close. If the Tracer being closed
> is the last tracer in the process, it will close all the span receivers.
> * We will have a TracerFactory that takes care of the details of creating the
> right span receivers based on the configuration. This removes some
> boilerplate that is currently needed to enable HTrace in an application or
> library. We can also make SpanReceiverFactory package-private since it will
> no longer need to be publicly visible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
