[
https://issues.apache.org/jira/browse/HTRACE-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641247#comment-14641247
]
Abraham Elmahrek commented on HTRACE-215:
-----------------------------------------
# htrace-core/src/main/java/org/apache/htrace/Sampler.java#L30 conditions don't
make sense any more in the comment.
Otherwise, seems cool. +1.
> Simplify the Sampler type
> -------------------------
>
> Key: HTRACE-215
> URL: https://issues.apache.org/jira/browse/HTRACE-215
> Project: HTrace
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-215.001.patch, HTRACE-215.002.patch,
> HTRACE-215.003.patch
>
>
> The Sampler type currently is parameterized on another type, like
> {{Sampler<T>}}. However, this is not really useful now that we have moved to
> a model of creating samplers from the {{SamplerFactory}}, since the
> {{SamplerFactory}} returns a {{Sampler<?>}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
