[ 
https://issues.apache.org/jira/browse/HTRACE-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680747#comment-14680747
 ] 

Wangda Tan commented on HTRACE-69:
----------------------------------

Thanks for comment [~iwasakims]!
I think YARN's requirement is a little different: In my mind, we need 
capability to decide if we need to do tracing for per-module/per-project, but 
we probably won't decide whether or not do trace the *at top level* (e.g. a 
single MR job). Basic MR job info are very important for us (such as 
container/app lifespan), I prefer to keep them for every YARN job.

I'm interested in how can HTrace plan to specify modules/projects tracing, do 
you have existing JIRAs open for them?

Regards,

> Filtering child spans by sampler
> --------------------------------
>
>                 Key: HTRACE-69
>                 URL: https://issues.apache.org/jira/browse/HTRACE-69
>             Project: HTrace
>          Issue Type: New Feature
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>
> Trace#startSpan respect the sampler given as argument only when there is no 
> ongoing span (i.e. when creating new root span).
> {code}
>   public static TraceScope startSpan(String description, Sampler<TraceInfo> 
> s, TraceInfo tinfo) {
>     Span span = null;
>     if (isTracing() || s.next(tinfo)) {
> {code}
> Adding API starting span if {{(isTracing() && s.next(tinfo))}} enables 
> filtering of child spans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to