[
https://issues.apache.org/jira/browse/HTRACE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710447#comment-14710447
]
Colin Patrick McCabe edited comment on HTRACE-214 at 8/25/15 2:15 AM:
----------------------------------------------------------------------
I added the release notes to the "environment" field of the JIRA "edit issue"
screen. I think our release-notes field is not enabled yet.. I started a
discussion on the mailing list.
Added the SpanReceiver and Sampler comments back in, with a small update.
I left TracerBuilder as-is for now. Tracer.java just has too much stuff in it,
so I like having this as a separate class. We can always revisit it in a
follow-on, though-- pre 4.0, at least.
Committed to 4.0. Thanks for the reviews, all.
was (Author: cmccabe):
I added the release notes to the "comments" field of the JIRA "edit issue"
screen. Added the SpanReceiver and Sampler comments back in, with a small
update.
I left TracerBuilder as-is for now. Tracer.java just has too much stuff in it,
so I like having this as a separate class. We can always revisit it in a
follow-on, though-- pre 4.0, at least.
Committed to 4.0. Thanks for the reviews, all.
> De-globalize Tracer.java
> ------------------------
>
> Key: HTRACE-214
> URL: https://issues.apache.org/jira/browse/HTRACE-214
> Project: HTrace
> Issue Type: Sub-task
> Affects Versions: 4.0
> Environment: release-notes: local-file-span-receiver.path
> configuration key changed to local.file.span.receiver.path for consistency
> local-file-span-receiver.capacity configuration key changed to
> local.file.span.receiver.capacity for consistency
> Default package for searching for SpanReceivers and Samplers was changed from
> org.apache.htrace.impl to org.apache.htrace.core.
> TracerId is now configured with % {tname} and similar, instead of ${tname}
> (to match the C client and make things easier when passing configuration
> through the shell.
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-214.001.patch, HTRACE-214.002.patch,
> HTRACE-214.003.patch, HTRACE-214.004.patch, HTRACE-214.005.patch,
> HTRACE-214.006.patch, HTRACE-214.007.patch, HTRACE-214.008.patch
>
>
> De-globalize Tracer.java.
> Currently, Tracer is a Singleton managed by TracerHolder. Instead, Tracer
> objects should be created by each process or library that needs to use
> HTrace. This enables a few things:
> * When the Tracer object is created, we can give it a name. Then we can use
> this name in the "process id" of all spans created by that tracer, rather
> than trying to scrape the JVM name using "questionable" methods.
> * SpanReceivers can be shared between multiple Tracer objects in the same
> process. The span receivers are reference counted. This should eliminate
> the "double tracing" issues we have had when tracing client libraries inside
> processes which also want tracing.
> * Tracers can be closed by calling Tracer#close. If the Tracer being closed
> is the last tracer in the process, it will close all the span receivers.
> * We will have a TracerFactory that takes care of the details of creating the
> right span receivers based on the configuration. This removes some
> boilerplate that is currently needed to enable HTrace in an application or
> library. We can also make SpanReceiverFactory package-private since it will
> no longer need to be publicly visible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
