[
https://issues.apache.org/jira/browse/HTRACE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14735912#comment-14735912
]
Colin Patrick McCabe commented on HTRACE-242:
---------------------------------------------
Hi Lewis,
We don't use external sites to post patches, just JIRA for now. There was a
long discussion on the mailing list about this. It boils down to wanting to
keep design and patch discussions in one place rather than fragmenting it
across the web.
The change looks good. Can you split this into two patches... one to fully
specify the versions of all Maven plugins, and one to set {{skipAssembly}} in
{{htrace-htraced/pom.xml}}? +1 once that's done.
> Fix HTrace pom.xml WARNING's
> ----------------------------
>
> Key: HTRACE-242
> URL: https://issues.apache.org/jira/browse/HTRACE-242
> Project: HTrace
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Lewis John McGibbney
> Fix For: 4.0
>
>
> Our CI builds on Jekins highlight the following
> {code}
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.htrace:htrace-webapp:war:4.0.0-incubating-SNAPSHOT
> [WARNING] 'build.plugins.plugin.version' for
> org.apache.maven.plugins:maven-war-plugin is missing. @ line 31, column 15
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.htrace:htrace-zipkin:jar:4.0.0-incubating-SNAPSHOT
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
> be unique: org.slf4j:slf4j-api:jar -> version 1.7.7 vs ${slf4j.version} @
> line 151, column 17
> [WARNING]
> [WARNING] Some problems were encountered while building the effective model
> for org.apache.htrace:htrace-htraced:jar:4.0.0-incubating-SNAPSHOT
> [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but
> found duplicate declaration of plugin
> org.apache.maven.plugins:maven-assembly-plugin @ line 64, column 15
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they
> threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support
> building such malformed projects.
> [WARNING]
> {code}
> This issue should address these warnings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
