[jira] [Commented] (HTRACE-249) Script and doc on how to publish website

[Colin Patrick McCabe (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HTRACE-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746081#comment-14746081
 ] 

Colin Patrick McCabe commented on HTRACE-249:
---------------------------------------------

Thanks, [~stack].

{code}
1       #!/bin/bash
{code}
Should be {{#!/usr/bin/env bash}}

{code}
if [ ! -d $GIT_DIR -o ! -d $SVN_DIR ]; then
{code}
Should have quotes around the GIT_DIR and SVN_DIR.  Similar elsewhere.

{code}
mvn clean package javadoc:aggregate site site:stage -DskipTests
{code}
Should have an {{|| die}} at the end

{code}
105     <!--
106             <configuration>
107               <additionalDependencies>
108                 <additionalDependency>
109                   <groupId>org.apache.hbase</groupId>
110                   <artifactId>hbase-common</artifactId>
111                   <version>${hbase.version}</version>
112                 </additionalDependency>
113                 <additionalDependency>
114                   <groupId>org.hamcrest</groupId>
115                   <artifactId>hamcrest-core</artifactId>
116                   <version>${hamcrest.version}</version>
117                 </additionalDependency>
118               </additionalDependencies>
119             </configuration>
120     -->
{code}
Do we need this change?


> Script and doc on how to publish website
> ----------------------------------------
>
>                 Key: HTRACE-249
>                 URL: https://issues.apache.org/jira/browse/HTRACE-249
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: stack
>         Attachments: publish.patch
>
>
> Includes update to news section with note on 4.0.0.
> Script was taken from hbase written by Misty Stanley Jones.
> Give me a +1 and I'll push the updated site.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)