[ 
https://issues.apache.org/jira/browse/HTRACE-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876394#comment-14876394
 ] 

Colin Patrick McCabe commented on HTRACE-254:
---------------------------------------------

+1.

Removing the LOG is compatible since it was private.  Agree that we should 
deprecate Span#child since its function is filled by the MilliSpan#Builder.

Looks good.

> Minor compatible API cleanup: Take name on Tracer construction, deprecate 
> Span#getChild
> ---------------------------------------------------------------------------------------
>
>                 Key: HTRACE-254
>                 URL: https://issues.apache.org/jira/browse/HTRACE-254
>             Project: HTrace
>          Issue Type: Task
>          Components: api
>            Reporter: stack
>            Assignee: stack
>         Attachments: 254.patch
>
>
> Converting HBase to use 4.0.0, tripped over a few small (compatible) changes 
> to the API.
> Other changes -- having detach, reattach, and annotating returning This -- as 
> well as adding some facility to Scope, would be incompatible so later.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to