[ 
https://issues.apache.org/jira/browse/HTRACE-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902904#comment-14902904
 ] 

Adrian Cole commented on HTRACE-260:
------------------------------------

There's no impact, as it was an optional field and it wasn't supported in the 
zipkin query interface. New zipkin will skip the field, the old zipkin stores 
and didn't use it, except for one UI screen. The old zipkin trace detail screen 
would display the value if it were present, except that the value recorded for 
duration was 1microsecond, so wouldn't make any sense. Zipkin hasn't had any 
issues raised on duration, so it is unlikely anyone looked at it.

> Update to latest zipkin thrift
> ------------------------------
>
>                 Key: HTRACE-260
>                 URL: https://issues.apache.org/jira/browse/HTRACE-260
>             Project: HTrace
>          Issue Type: Bug
>          Components: zipkin
>            Reporter: Adrian Cole
>            Priority: Minor
>         Attachments: HTRACE-260.patch
>
>
> Zipkin has recently dropped the Annotation.duration field, as well added new 
> constants. This implicitly this fixes incorrect use of the obsolete field: 
> HTrace always set duration to 1 microsecond.
> See https://github.com/openzipkin/zipkin/pull/717



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to