[
https://issues.apache.org/jira/browse/HTRACE-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934777#comment-14934777
]
Colin Patrick McCabe commented on HTRACE-235:
---------------------------------------------
Should we be shading the Kafka dependency in htrace-zipkin? It seems like this
might cause issues for people who are using a different version of Kafka.
Can you please add documentation to Transport specifying that it is not
thread-safe, and relies on external synchronization?
{code}
} // catch
} // while
{code}
Please no end-of-block comments.
{{ITZipkinReceiver.java}}: Hmm. What does IT stand for? We typically have
"Test" somewhere in the name of tests.
{{htrace-zipkin/src/test/resources/log4j.properties}}: It seems like this is
something we might want to do for other subprojects. Can you create a separate
JIRA to add {{log4j.properties}} files for submodule tests?
thanks
> htrace-zipkin - add Kafka transport support
> --------------------------------------------
>
> Key: HTRACE-235
> URL: https://issues.apache.org/jira/browse/HTRACE-235
> Project: HTrace
> Issue Type: New Feature
> Reporter: Cosmin Lehene
> Assignee: Cosmin Lehene
> Fix For: 4.1
>
> Attachments: HTRACE-235.1.patch, HTRACE-235.2.patch,
> HTRACE-235.4.patch, HTRACE-235.patch
>
>
> Currently htrace-zipkin writes to the Scribe Thrift endpoint. However, Scribe
> is pretty much dead (although this is just Thrift interface so doesn't really
> need Scribe).
> A Kafka receiver would likely be useful not only for htrace-zipkin, so I
> think it could live outside. The htrace-native would be harder to get working
> with Kafka as there no supported Kafka native client (perhaps this could be
> experimented with https://github.com/edenhill/librdkafka).
> Writing to Kafka would also be possible by having a service that translates
> from Scribe Thrift to Kafka messages, however it would be nice to get the
> Kafka producer semantics on the client side (e.g. sync, async, batch size,
> etc.). This will come at the cost of having the Kafka producer as a
> dependency (larger jar), though as well as have a more complex receiver
> (multiple threads from the Kafka producer).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
