[
https://issues.apache.org/jira/browse/HTRACE-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940754#comment-14940754
]
Masatake Iwasaki commented on HTRACE-275:
-----------------------------------------
Thanks for quick work, [~cmccabe].
{code}
public boolean addSampler(Sampler sampler) {
throw new RuntimeException("Can't add a new sampler to the NullTracer.");
}
{code}
I think NullTracer should not fail in the code path non-null Tracer does not
fail. How about logging DEBUG message and just return false?
Other part looks good to me.
> Add NullTracer which never creates a trace span
> -----------------------------------------------
>
> Key: HTRACE-275
> URL: https://issues.apache.org/jira/browse/HTRACE-275
> Project: HTrace
> Issue Type: Improvement
> Components: api
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-275.001.patch
>
>
> [~iwasakims] suggested adding a {{NullTracer}} which never creates a trace
> span. This would be more convenient than checking tracer objects against
> null in some cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
