[
https://issues.apache.org/jira/browse/HTRACE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091296#comment-15091296
]
Colin Patrick McCabe commented on HTRACE-317:
---------------------------------------------
Thanks for fixing this up, [~iwasakims].
A few minor nits:
{code}
+ Tracer tracer = new Tracer.Builder("MyApp").conf(conf).build();
{code}
The Builder constructor which takes a name was deprecated in HTRACE-254, so
this should probably be:
{code}
+ Tracer tracer = new Tracer.Builder().name("MyApp").conf(conf).build();
{code}
{code}
+That's it! `Tracer.wrap()` takes two argument
+(a runnable or a callable and span description)
{code}
"arguments" should be plural
+1. Can fix up the nits on commit if you like
> Docs for adding tracing to an application are incorrect
> -------------------------------------------------------
>
> Key: HTRACE-317
> URL: https://issues.apache.org/jira/browse/HTRACE-317
> Project: HTrace
> Issue Type: Bug
> Components: docs
> Affects Versions: 4.0.1
> Reporter: Sean Busbey
> Assignee: Masatake Iwasaki
> Priority: Critical
> Attachments: HTRACE-317.001.patch
>
>
> The docs for adding tracing state:
> {code}
> Span computationSpan = tracer.newScope("Expensive computation.");
> try {
> //expensive computation here
> } finally {
> computationSpan.stop();
> }
> {code}
> the {{tracer.newScope}} method returns a TraceScope object. That object has a
> {{close}} method, not {{stop}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
