[
https://issues.apache.org/jira/browse/HTRACE-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin Patrick McCabe updated HTRACE-274:
----------------------------------------
Fix Version/s: (was: 4.1)
Description:
https://github.com/apache/incubator-htrace/blob/master/htrace-zipkin/src/main/java/org/apache/htrace/impl/ZipkinSpanReceiver.java#L239-L255
https://github.com/apache/incubator-htrace/blob/master/htrace-hbase/src/main/java/org/apache/htrace/impl/HBaseSpanReceiver.java#L175-L191
Doing a code duplication analysis revealed several others. I'm thinking we
should add pmd (http://maven.apache.org/plugins/maven-pmd-plugin/) and perhaps
Sonar.
was:
https://github.com/apache/incubator-htrace/blob/master/htrace-zipkin/src/main/java/org/apache/htrace/impl/ZipkinSpanReceiver.java#L239-L255
https://github.com/apache/incubator-htrace/blob/master/htrace-hbase/src/main/java/org/apache/htrace/impl/HBaseSpanReceiver.java#L175-L191
Doing a code duplication analysis revealed several others. I'm thinking we
should add pmd (http://maven.apache.org/plugins/maven-pmd-plugin/) and perhaps
Sonar.
> XSpanReceiver code duplication
> ------------------------------
>
> Key: HTRACE-274
> URL: https://issues.apache.org/jira/browse/HTRACE-274
> Project: HTrace
> Issue Type: Bug
> Components: hbase, zipkin
> Reporter: Cosmin Lehene
> Priority: Blocker
>
> https://github.com/apache/incubator-htrace/blob/master/htrace-zipkin/src/main/java/org/apache/htrace/impl/ZipkinSpanReceiver.java#L239-L255
> https://github.com/apache/incubator-htrace/blob/master/htrace-hbase/src/main/java/org/apache/htrace/impl/HBaseSpanReceiver.java#L175-L191
> Doing a code duplication analysis revealed several others. I'm thinking we
> should add pmd (http://maven.apache.org/plugins/maven-pmd-plugin/) and
> perhaps Sonar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
