[
https://issues.apache.org/jira/browse/HTRACE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795774#comment-15795774
]
stack commented on HTRACE-393:
------------------------------
[~raam86] Thank you for the the PR. Does the fix work for you? Mind attaching
here as a patch so we can run our little test suite so I can push it?
> Binary annotations are being shown as base64 in the zipkin frontend
> --------------------------------------------------------------------
>
> Key: HTRACE-393
> URL: https://issues.apache.org/jira/browse/HTRACE-393
> Project: HTrace
> Issue Type: Bug
> Components: zipkin
> Affects Versions: 4.3
> Reporter: Raam
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> As discussed in the mailing list:
> Seems like HTraceToZipkinConverter.java tags all binary annotations as the
> BYTES thrift data type although a string is being sent
> https://github.com/apache/incubator-htrace/blob/master/htrace-zipkin/src/main/java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java#L156.
> A string is always sent since this is the signature of
> TraceScope.addKVAnnotation: public void addKVAnnotation(String key, String
> value)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
