VGalaxies commented on code in PR #2589:
URL:
https://github.com/apache/incubator-hugegraph/pull/2589#discussion_r1681062295
##########
hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml:
##########
@@ -129,7 +129,7 @@
<!-- Use mixed async way to output logs -->
<logger name="org.apache.hugegraph" level="INFO" additivity="false">
<appender-ref ref="file" />
- <appender-ref ref="console" />
+<!-- <appender-ref ref="console" />-->
Review Comment:
It needs to be discussed in different situations because this configuration
file will be used by both the IDE launch and script usage:
- If started using a script, take pd as an example, the output of the
command line will be redirected to hugegraph-pd-stdout.log, and the logs
defined within the log4j2.xml range will be obtained in hugegraph-pd.log (there
will be a delay). In fact, the content of the hugegraph-pd.log log is basically
the same as that in hugegraph-pd-stdout.log.
- If started using an IDE, still using pd as an example, the command line
output (pd runtime log) will be displayed in the RUN panel, and you will still
get the logs within the range defined in log4j2.xml in the hugegraph-pd.log
(there will be a delay).
The conclusion is that if the script is used to start, the console appender
is unnecessary. If the IDE is used to start, the console appender is meaningful
(for timely observation of logs). Considering the delay in the generation of
hugegraph-pd.log logs, it is recommended to keep the console appender.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
