imbajin commented on code in PR #56:
URL:
https://github.com/apache/incubator-hugegraph-ai/pull/56#discussion_r1694947991
##########
hugegraph-llm/src/hugegraph_llm/config/generate.py:
##########
@@ -22,4 +22,7 @@
if __name__ == '__main__':
parser = argparse.ArgumentParser(description='Generate hugegraph-llm
config file')
- settings.generate_env()
+ parser.add_argument("-U", "--update", action="store_true", help="Update
the config file")
Review Comment:
maybe `-u` is more user-friendly? (if no conflicts found)
Also a little confused, update. Why do env files need to be scripted once?
Isn't the change application checked by default? @ChenZiHong-Gavin
##########
hugegraph-llm/src/hugegraph_llm/config/generate.py:
##########
@@ -22,4 +22,7 @@
if __name__ == '__main__':
parser = argparse.ArgumentParser(description='Generate hugegraph-llm
config file')
- settings.generate_env()
+ parser.add_argument("-U", "--update", action="store_true", help="Update
the config file")
Review Comment:
maybe `-u` is more user-friendly? (if no conflicts found)
Also a little confused, update. Why do `.env` files need to be scripted
once? Isn't the change application checked by default? @ChenZiHong-Gavin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
