VGalaxies commented on code in PR #2649:
URL:
https://github.com/apache/incubator-hugegraph/pull/2649#discussion_r1827627364
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/EdgeId.java:
##########
@@ -49,15 +49,14 @@ public class EdgeId implements Id {
HugeKeys.OTHER_VERTEX
};
- private final Id ownerVertexId;
- private final Directions direction;
- private final Id edgeLabelId;
- private final Id subLabelId;
- private final String sortValues;
- private final Id otherVertexId;
-
- private final boolean directed;
- private String cache;
+ protected final Id ownerVertexId;
+ protected final Id edgeLabelId;
+ protected final Id subLabelId;
+ protected final Id otherVertexId;
+ protected final Directions direction;
+ protected final boolean directed;
+ protected String sortValues;
+ protected String cache;
Review Comment:
better keep the order
and why not use `final` for all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
