imbajin commented on code in PR #209:
URL:
https://github.com/apache/incubator-hugegraph-ai/pull/209#discussion_r2043921971
##########
hugegraph-python-client/src/pyhugegraph/utils/huge_config.py:
##########
@@ -45,7 +44,7 @@ def __post_init__(self):
else:
try:
response = requests.get(
- f"http://{self.ip}:{self.port}/versions";, timeout=0.5
+ f"{self.url}/versions", timeout=0.5
Review Comment:
Perhaps we should add a compatibility check/adapter here.
If str does not start with `http/https`, it will automatically concatenate
`http://` to avoid making modifications at all original calls. 🤔 (It also
avoids the risk of errors caused by omitted modifications)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
