Copilot commented on code in PR #265:
URL:
https://github.com/apache/incubator-hugegraph-ai/pull/265#discussion_r2126678179
##########
hugegraph-llm/src/hugegraph_llm/utils/graph_index_utils.py:
##########
@@ -46,7 +48,7 @@ def get_graph_index_info():
def clean_all_graph_index():
- VectorIndex.clean(str(os.path.join(resource_path,
huge_settings.graph_name, "graph_vids")))
+ VectorIndex.clean(str(os.path.join(resource_path,
huge_settings.graph_name, "graph_vids",
llm_settings.embedding_type)),Embeddings().get_embedding())
Review Comment:
The call to VectorIndex.clean is passing the entire embedding object instead
of its model name. Use 'getattr(Embeddings().get_embedding(), "model_name",
null)' to extract the model name.
```suggestion
VectorIndex.clean(str(os.path.join(resource_path,
huge_settings.graph_name, "graph_vids", llm_settings.embedding_type)),
getattr(Embeddings().get_embedding(), "model_name", None))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
