imbajin commented on code in PR #2862:
URL:
https://github.com/apache/incubator-hugegraph/pull/2862#discussion_r2313276037
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/IdGenerator.java:
##########
@@ -128,14 +129,19 @@ public static int compareType(Id id1, Id id2) {
public static class StringId implements Id {
protected String id;
+ protected byte[] bytes;
Review Comment:
**Thread Safety Concern**: The lazy initialization pattern used here is not
thread-safe. If multiple threads access the same StringId instance
simultaneously, race conditions could occur during the lazy initialization of
`id` and `bytes` fields. Consider using volatile fields or synchronization to
ensure thread safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
