imbajin commented on code in PR #423: URL: https://github.com/apache/incubator-hugegraph-doc/pull/423#discussion_r2533201461
########## content/cn/docs/quickstart/computing/hugegraph-vermeer.md: ########## @@ -16,6 +16,144 @@ master 是负责通信、转发、汇总的节点，计算量和占用资源量 ### 1.2 运行方法 +1. **方案一：Docker Compose（推荐）** + +确保docker-compose.yaml存在于您的项目根目录中。如果没有，以下是一个示例： +```yaml +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +version: '3.8' + +services: + vermeer-master: + image: hugegraph/vermeer + container_name: vermeer-master + volumes: + - ~/:/go/bin/config # Change here to your actual config path Review Comment: ‼️ **Volume 映射路径错误 - 安全风险** 将 `~/` 映射到容器内部会暴露整个用户主目录,这是严重的安全问题。应该: ```suggestion - ./config:/go/bin/config # 仅映射项目配置目录 ``` 或者明确指定配置文件路径,例如 `./vermeer-config:/go/bin/config` ########## content/cn/docs/quickstart/computing/hugegraph-vermeer.md: ########## @@ -16,6 +16,144 @@ master 是负责通信、转发、汇总的节点，计算量和占用资源量 ### 1.2 运行方法 +1. **方案一：Docker Compose（推荐）** + +确保docker-compose.yaml存在于您的项目根目录中。如果没有，以下是一个示例： +```yaml +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +version: '3.8' + +services: + vermeer-master: + image: hugegraph/vermeer Review Comment: ‼️ **缺少端口映射配置** Docker Compose 配置中没有暴露服务端口,用户无法从宿主机访问 Vermeer 服务(如 8688 端口)。需要添加: ```suggestion vermeer-master: image: hugegraph/vermeer container_name: vermeer-master ports: - "8688:8688" # 根据实际配置的端口调整 volumes: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
