Re: [PR] optimize(api): disable GraphSpaceAPI and ManagerAPI in standalone mode [hugegraph]

[via GitHub]

imbajin commented on code in PR #2966:
URL: https://github.com/apache/hugegraph/pull/2966#discussion_r2936756643


##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/core/GraphManager.java:
##########
@@ -276,7 +276,7 @@ private static String serviceId(String graphSpace, 
Service.ServiceType type,
                      .replace("_", "-").toLowerCase();

Review Comment:
   ⚠️ 
Suggestion: 
rename public 
boolean 
usePD() 
to follow 
Java boolean 
getter 
conventions and 
add Javadoc
   
   Publicly exposing 
usePD() 
increases the 
class 
surface; 
prefer a 
clearer name 
such as 
isPdEnabled() 
and add 
javadoc 
describing PD 
semantics. 
Example:
   
   /** Returns true if placement driver (PD / hstore) is 
configured/available. */
   public boolean 
isPdEnabled() 
{
       
return
 
this.PDExist;
   }
   
   If callers 
outside core 
need the 
current 
name, 
keep 
usePD() 
as a 
deprecated 
delegate that 
calls the 
new method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@hugegraph.apache.org
For additional commands, e-mail: issues-h...@hugegraph.apache.org