bitflicker64 commented on code in PR #2962:
URL: https://github.com/apache/hugegraph/pull/2962#discussion_r2937152234
##########
hugegraph-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/service/PDService.java:
##########
@@ -1735,6 +1737,17 @@ public void updatePdRaft(Pdpb.UpdatePdRaftRequest
request,
node.changePeers(config, status -> {
if (status.isOk()) {
log.info("updatePdRaft, change peers success");
+ // Refresh IpAuthHandler so newly added peers are not
blocked
+ IpAuthHandler handler = IpAuthHandler.getInstance();
+ if (handler != null) {
Review Comment:
Thanks for pointing that out. I’ve added a regression test
(RaftEngineIpAuthIntegrationTest) that exercises the full path changePeerList →
changePeers → callback → handler.refresh(). It also includes a failure-path
test to ensure the allowlist is not refreshed when the peer update fails.
Please let me know if you think any additional coverage would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
