imbajin commented on code in PR #2976:
URL: https://github.com/apache/hugegraph/pull/2976#discussion_r2970704307
##########
docker/docker-compose-3pd-3store-3server.yml:
##########
@@ -30,13 +30,11 @@ volumes:
hg-store2-data:
# ── Shared service defaults ──────────────────────────────────────────
-# TODO: remove volume mounts below once images are published with new
entrypoints
x-pd-common: &pd-common
image: hugegraph/pd:${HUGEGRAPH_VERSION:-latest}
pull_policy: missing
restart: unless-stopped
networks: [hg-net]
Review Comment:
> `pull_policy: missing` + `HUGEGRAPH_VERSION:-latest` can keep using a
locally cached (older) image instead of pulling the updated one. Since this PR
removes the bind-mounted entrypoints/scripts and now relies on the images to
contain the new entrypoint logic, using a cached image can lead to
startup/config behavior that no longer matches these compose files. Consider
switching the compose defaults to `pull_policy: always` (or pin
`HUGEGRAPH_VERSION` to a known-good tag and document the required minimum image
version).
I agree the image update behavior should be explicit, but I don’t think
switching this file to pull_policy: always is the right move yet.
Right now these three images do not have stable release tags like `1.7.0`,
so always pulling latest on every docker compose up would make production
deployments pick up potentially breaking changes without an explicit upgrade
step. For now, I’d prefer to keep `pull_policy: missing` and document the
manual refresh workflow here instead.
If users want to force a refresh, run: (could refer it in
https://github.com/apache/hugegraph/pull/2963)
```bash
docker compose pull pd store server
docker compose up -d pd store server
```
Once release tags are available for all three images, we can revisit pinning
the version and updating the compose defaults accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
