rdblue commented on a change in pull request #348: Avoid floating point number
ordering NaN semantics
URL: https://github.com/apache/incubator-iceberg/pull/348#discussion_r317413690
##########
File path: site/docs/spec.md
##########
@@ -206,19 +206,22 @@ The schema of a manifest file is a struct called
`manifest_entry` with the follo
| **`104 file_size_in_bytes`** | `long` |
Total file size in bytes
|
| ~~**`105 block_size_in_bytes`**~~ | `long` |
**Deprecated. Always write a default value and do not read.**
|
| **`106 file_ordinal`** | `optional int` |
Ordinal of the file w.r.t files with the same partition tuple and snapshot id
|
-| **`107 sort_columns`** | `optional list` |
Columns the file is sorted by
|
+| **`107 sort_columns`** | `optional list` |
Columns the file is sorted by [2]. If a column has type `float` or `double` and
contains `NaN`, it must not be in `sort_columns`.
|
Review comment:
Sort columns is currently not used and we intend to remove it. It sounded
like a good idea at first, but we will need direction and null handling rules.
What we are planning to do instead is to define sort orders in table metadata
and attach them to files by ID. So don't worry about this, we'll remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
