chenjunjiedada commented on a change in pull request #374: Migrate spark table
to iceberg table
URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r319348741
##########
File path: hive/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -102,7 +102,7 @@ private TServer newThriftServer(TServerSocket socket,
HiveConf conf) throws Exce
.transportFactory(new TTransportFactory())
.protocolFactory(new TBinaryProtocol.Factory())
.minWorkerThreads(3)
- .maxWorkerThreads(5);
+ .maxWorkerThreads(10);
Review comment:
Agree to make it configurable.
The small threads number is OK for me as long as it is enough for new tests.
So I'd like to know if we can release the thread/connection when each unit test
finish?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
