rdsr commented on a change in pull request #529: Add hadoop table catalog (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/529#discussion_r334147493
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
##########
@@ -51,13 +54,13 @@ public HadoopCatalog(Configuration conf) {
}
this.hdfsRoot = hdfsRoot + "/" + ICEBERG_HADOOP_WAREHOUSE_BASE;
Review comment:
this was slightly confusing, instead of `hdfsRoot` we should name this
variable `warehousePath` or something similar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
