rdblue commented on a change in pull request #499: Add persistent IDs to partition fields (WIP) URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r336604869
########## File path: core/src/main/java/org/apache/iceberg/ManifestReader.java ########## @@ -57,6 +57,8 @@ .addAll(CHANGE_COLUMNS) .add("value_counts", "null_value_counts", "lower_bounds", "upper_bounds") .build(); + private static final String PARTITION_SPEC = "partition-spec"; + private static final String SCHEMA = "schema"; Review comment: These changes aren't functional. Can you please remove them? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org