jerryshao commented on a change in pull request #681: [ISSUE #680] Fix the
listTable in HadoopCatalog
URL: https://github.com/apache/incubator-iceberg/pull/681#discussion_r353584606
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
##########
@@ -195,6 +198,8 @@ public void renameTable(TableIdentifier from,
TableIdentifier to) {
throw new UnsupportedOperationException("Cannot rename Hadoop tables");
}
+ private static final PathFilter TABLE_FILTER = path ->
path.getName().endsWith(TABLE_METADATA_FILE_EXTENSION);
Review comment:
Should this class variable move to the top of the class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
