chenjunjiedada commented on a change in pull request #845: Add persistent IDs
to partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r402925293
##########
File path: core/src/test/java/org/apache/iceberg/TestMergeAppend.java
##########
@@ -395,6 +396,47 @@ public void testChangedPartitionSpec() {
initialManifest, pending.manifests().get(1));
}
+ @Test
+ public void testUpdatePartitionSpecFieldIds() {
+ TableMetadata base = readMetadata();
+
+ // build the new spec using the table's schema, which uses fresh IDs
+ PartitionSpec newSpec = PartitionSpec.builderFor(base.schema())
Review comment:
Can we add a unit test that has two manifests with the different specs of
the same source field, and then check whether the partition field ids of
manifest entries are different?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
