openinx commented on a change in pull request #913: Add v2 manifests (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/913#discussion_r407299115
##########
File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
##########
@@ -257,21 +255,25 @@ public Object get(int i) {
case 2:
return specId;
case 3:
- return snapshotId;
+ return sequenceNumber;
Review comment:
Here we're changing the position of snapshotId/addedFilesCount/ ... etc,
will it break the compatibility ? I mean the new code couldn't read the old
data manifest file ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
