rdblue commented on a change in pull request #922: [WIP] Add partition spec evolution URL: https://github.com/apache/incubator-iceberg/pull/922#discussion_r409172592
########## File path: api/src/main/java/org/apache/iceberg/UpdatePartitionSpec.java ########## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import org.apache.iceberg.exceptions.CommitFailedException; + +/** + * API for partition spec evolution. + * <p> + * When committing, these changes will be applied to the current table metadata. Commit conflicts + * will not be resolved and will result in a {@link CommitFailedException}. + */ +public interface UpdatePartitionSpec extends PendingUpdate<PartitionSpec> { + + /** Update the current partition spec to a new partition spec. + * <p> + * Partition field IDs of the new partitionSpec may be updated during the commit. + * + * @param partitionSpec new partition spec to update + * @return this for method chaining + */ + UpdatePartitionSpec update(PartitionSpec partitionSpec); Review comment: Exposing a method like this requires more validation work because we have to compare the two partition specs by detecting the changes to each field (by ID) and ensuring those changes are allowed. Ensuring only allowed changes are accepted is easier if the user tells Iceberg their intent using methods like `addIdentity(String name)`. This method would also be difficult for callers to use correctly. The public `PartitionSpec` builder API doesn't allow setting custom field IDs. We could expose custom field IDs, but that's more complication for the user to worry about. We could also reassign the IDs if the fields look equivalent, but we don't really know if that's correct. Overall, I think it will be easier for maintainers and users to remove this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
