rdblue commented on a change in pull request #935: Internal relocated version of Guava URL: https://github.com/apache/incubator-iceberg/pull/935#discussion_r410477492
########## File path: versions.lock ########## @@ -20,7 +20,6 @@ com.google.code.gson:gson:2.2.4 (2 constraints: 9518bfd2) com.google.errorprone:error_prone_annotations:2.3.3 (2 constraints: 161a2544) com.google.flatbuffers:flatbuffers-java:1.9.0 (2 constraints: e5199714) com.google.guava:failureaccess:1.0.1 (1 constraints: 140ae1b4) -com.google.guava:guava:28.0-jre (21 constraints: 88453dad) Review comment: Two more things: For modules that need a dependency on a different guava version, does excluding the transitive dependency work? What do you think about keeping guava dependencies for modules that haven't been moved? Then we could migrate one module at a time, which would cut down on commit conflicts. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
