rdblue commented on a change in pull request #828: iceberg-spark changes for
vectorized reads
URL: https://github.com/apache/incubator-iceberg/pull/828#discussion_r410510938
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java
##########
@@ -72,7 +72,7 @@ void readBatchOfDictionaryIds(IntVector intVector, int
startOffset, int numValue
}
void readBatchOfDictionaryEncodedLongs(FieldVector vector, int startOffset,
int numValuesToRead, Dictionary dict,
- NullabilityHolder nullabilityHolder) {
+ NullabilityHolder nullabilityHolder,
int typeWidth) {
Review comment:
These changes look concerning. It looks like the old offset (only index)
must not have been correct. If so, there are places where
`getDataBuffer().setLong(...)` and similar methods are called but aren't
updated like these. Are those cases bugs as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
