rdblue commented on code in PR #7412:
URL: https://github.com/apache/iceberg/pull/7412#discussion_r1264750328
##########
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##########
@@ -36,6 +37,19 @@ public class GCPProperties implements Serializable {
public static final String GCS_CHANNEL_READ_CHUNK_SIZE =
"gcs.channel.read.chunk-size-bytes";
public static final String GCS_CHANNEL_WRITE_CHUNK_SIZE =
"gcs.channel.write.chunk-size-bytes";
+ // For BigQuery BigLake Metastore.
+ // The endpoint of BigLake API.
+ // Optional, default to BigLakeCatalog.DEFAULT_BIGLAKE_SERVICE_ENDPOINT.
+ public static final String BIGLAKE_ENDPOINT = "biglake.endpoint";
+ // The GCP project ID. Required.
+ public static final String BIGLAKE_PROJECT_ID = "biglake.project-id";
Review Comment:
Is this specific to BigLake? The comment makes it sound like it's a GCP
project, not a BigLake project?
In general, I'm wondering if these all require a `biglake.` prefix. We could
probably use the more standard `uri`, then it doesn't seem like a bad idea to
have catalog config properties like `project-id`, `region`, and `catalog-id`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
