aokolnychyi commented on a change in pull request #936:
URL: https://github.com/apache/incubator-iceberg/pull/936#discussion_r412372341
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -52,6 +52,14 @@ public static TableMetadata newTableMetadata(Schema schema,
PartitionSpec spec,
String location,
Map<String, String> properties)
{
+ return newTableMetadata(schema, spec, location, properties,
DEFAULT_TABLE_FORMAT_VERSION);
+ }
+
+ static TableMetadata newTableMetadata(Schema schema,
+ PartitionSpec spec,
+ String location,
+ Map<String, String> properties,
+ int formatVersion) {
Review comment:
Is it something we want to annotate with @VisibleForTesting?
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -52,6 +52,14 @@ public static TableMetadata newTableMetadata(Schema schema,
PartitionSpec spec,
String location,
Map<String, String> properties)
{
+ return newTableMetadata(schema, spec, location, properties,
DEFAULT_TABLE_FORMAT_VERSION);
+ }
+
+ static TableMetadata newTableMetadata(Schema schema,
+ PartitionSpec spec,
+ String location,
+ Map<String, String> properties,
+ int formatVersion) {
Review comment:
Is it something we want to annotate with `@VisibleForTesting`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
